Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stateful application failover status injection feature gate #5897

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Add stateful application failover status injection feature gate #5897

merged 1 commit into from
Nov 30, 2024

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a feature gate StatefulFailoverInjection which controls whether Karmada collects state information from the source cluster during a failover event for stateful applications and injects this information into the application configuration when it is moved to the target cluster.

Which issue(s) this PR fixes:
Part of #5788

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Introduced feature gate `StatefulFailoverInjection` to control whether Karmada collects and injects state information during a failover event for stateful application.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 29, 2024
@RainbowMango
Copy link
Member Author

cc @mszacillo @XiShanYongYe-Chang
We better have a feature gate for this feature, as we will continue to iterate it in the following releases.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
@RainbowMango RainbowMango force-pushed the pr_stateful_injection_gate branch from 76feb6f to a910fa8 Compare November 29, 2024 08:19
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
@karmada-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@RainbowMango
Copy link
Member Author

Forced pushed to fix the unit test which requires enable feature gate.

@RainbowMango
Add stateful application failover status injection feature gate
58c3765 
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango force-pushed the pr_stateful_injection_gate branch from a910fa8 to 58c3765 Compare November 29, 2024 08:27
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (54be414) to head (58c3765).

Files with missing lines Patch % Lines
pkg/controllers/binding/common.go 0.00% 5 Missing ⚠️
pkg/controllers/applicationfailover/common.go 78.57% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5897   +/-   ##
=======================================
  Coverage   46.28%   46.28%           
=======================================
  Files         663      663           
  Lines       54762    54766    +4     
=======================================
+ Hits        25344    25348    +4     
  Misses      27789    27789           
  Partials     1629     1629
Flag Coverage Δ
unittests 46.28% <57.89%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango added this to the v1.12 milestone Nov 30, 2024
@RainbowMango
Copy link
Member Author

Let's move forward as another PR #5899 might conflict with this.

@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango RainbowMango added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2024
@karmada-bot karmada-bot merged commit 0f2e0cc into karmada-io:master Nov 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

@Garrybest Garrybest Awaiting requested review from Garrybest

@jwcesign jwcesign Awaiting requested review from jwcesign

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
4 participants
@RainbowMango @karmada-bot @codecov-commenter @XiShanYongYe-Chang